Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Web] Can not download selected photos in public shared album (via public share link) #5998

Closed
1 of 3 tasks
tienducle opened this issue Dec 27, 2023 · 5 comments
Closed
1 of 3 tasks
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tienducle
Copy link

The bug

As discussed in this discord thread, when browsing a public shared album using a public share link, the download button always downloads all photos of the album and it is not possible to download only the selected photos.

The OS that Immich Server is running on

Debian

Version of Immich Server

v1.91.4

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Create a new album
2. Add 3 photos to it
3. Create a public share link
4. View album using public share link
5. Select 2 photos
6. Click download

**Expected result**: ZIP file contains the 2 selected photos

**Actual result**: ZIP file contains all 3 photos

Additional information

No response

@tienducle tienducle added the bug Something isn't working label Dec 27, 2023
@alextran1502
Copy link
Contributor

Download in individual public shared link works.

The bug here is in public shared link for an album, the top menu doesn't show up when in selection mode

@tienducle
Copy link
Author

Do you have any ETA on this?

@XenorPLxx
Copy link

I can confirm this is reproducible, just had the same thing occur, had to work around by creating another link with just the photos someone wanted.

@jrasm91 jrasm91 added the good first issue Good for newcomers label Feb 12, 2024
@RavidYael
Copy link
Contributor

Hi everyone,
I've noticed this issue and I'm interested in working on it. I'll do my best to figure it out and submit a solution.

@jrasm91
Copy link
Contributor

jrasm91 commented Feb 22, 2024

This has already been fixed by #7227.

@jrasm91 jrasm91 closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants