-
Notifications
You must be signed in to change notification settings - Fork 1.8k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Delete Duplicated Media #644
Comments
Hi @swimminsparrow, we've already implemented duplicate identifier with sha1 checksum. A tool for managing and deleting duplicated content is also our further work. |
Hi have this situation:
|
This sounds like a bug. Where did you get the app? Can you provide more information on your setup and device info? |
Android version: 1.28.0 build.38 |
@swimminsparrow your backend version is really old. You'd better upgrade to the latest version 1.28 |
The dedup feature has been available since 1.27. We are going with the convention that the mobile app and the server must be on the same version to ensure compatibility. |
Hi @alextran1502 @panoti how can i upgrade the server version? thanks |
You can do |
Ok thank you. I suppose the feature does not work retroactively so i should clean the current situation with duplicates and make further check for the new uploads |
FYI, new upload won't run into problem with duplication since we have the checking mechanism in place. The only edge case is the two identical files with two version, one is compressed and one is original, which will cause the duplication. |
I'm also seeing some duplicate data after an initial upload via googlephotos takeout, then syncing my device photos. Guessing thats likely the edge case you speak of @alextran1502? |
@joeShuff if the file is compressed then we will see the duplication since the hash value is different with the uncompressed file |
In the android app it shows duplicated files, on the web app it doesn't, after logging out and in again and re-uploading. For example, if I go to the date 26 nov on the android app, it shows 6 pictures, 3 unique and 3 duplicated. If I go to the date 26 nov on my computer, it shows 3 picutres, 3 unique and 0 duplicated. After closing and re-opening the app this got fixed, but if I didn't close the app it stayed "duplicated". |
It's worth noting too, that the sha1 hash is only unique per user. |
Also I just noticed another problem, the "Backup up photo's and video's" counter is 0 (because the photo's and video's are already uploaded ig?) |
This might be the state glitch when uploading and updating the timeline. I noticed that sometime the websocket doesn't close properly lead to two uploading events triggered and showing duplication. If closing and reopening the app fix it, this is just cosmetic bug and we will get to it sometimes in the future |
If this is not correct, please open a separate issue and provide the steps you have taken to arrive at the problem. I am not sure which operations were done and what is the expectation outcome from your brief report |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Feature detail
A tool for managing and deleting duplicated content could be useful, checking the hash or the filename?
Platform
Web
The text was updated successfully, but these errors were encountered: