Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Delete Duplicated Media #644

Closed
swimminsparrow opened this issue Sep 8, 2022 · 17 comments
Closed

[Feature]: Delete Duplicated Media #644

swimminsparrow opened this issue Sep 8, 2022 · 17 comments
Labels
feature needs triage Bug that needs triage from maintainer

Comments

@swimminsparrow
Copy link

Feature detail

A tool for managing and deleting duplicated content could be useful, checking the hash or the filename?

Platform

Web

@swimminsparrow swimminsparrow added feature needs triage Bug that needs triage from maintainer labels Sep 8, 2022
@panoti
Copy link
Contributor

panoti commented Sep 8, 2022

Hi @swimminsparrow, we've already implemented duplicate identifier with sha1 checksum. A tool for managing and deleting duplicated content is also our further work.

@swimminsparrow
Copy link
Author

Hi have this situation:

  1. Logged in with a device and sync a folder
  2. Logout
  3. Logged in with same device and same user and sync same folder
  4. A new dir under immich-data has been created and all the previous media have been resynced. The application shows both the "old" content and the new. Even if they are the same content

@alextran1502
Copy link
Contributor

Hi have this situation:

  1. Logged in with a device and sync a folder
  2. Logout
  3. Logged in with same device and same user and sync same folder
  4. A new dir under immich-data has been created and all the previous media have been resynced. The application shows both the "old" content and the new. Even if they are the same content

This sounds like a bug. Where did you get the app?

Can you provide more information on your setup and device info?

@swimminsparrow
Copy link
Author

Android version: 1.28.0 build.38
Server version: 1.26.0
Server OS: 2022-09-06-raspios-bullseye-arm64

@panoti
Copy link
Contributor

panoti commented Sep 8, 2022

@swimminsparrow your backend version is really old. You'd better upgrade to the latest version 1.28

@alextran1502
Copy link
Contributor

Android version: 1.28.0 build.38 Server version: 1.26.0 Server OS: 2022-09-06-raspios-bullseye-arm64

The dedup feature has been available since 1.27. We are going with the convention that the mobile app and the server must be on the same version to ensure compatibility.

@swimminsparrow
Copy link
Author

Hi @alextran1502 @panoti how can i upgrade the server version? thanks

@alextran1502
Copy link
Contributor

You can do docker-compose pull then docker-compose up

@swimminsparrow
Copy link
Author

Ok thank you. I suppose the feature does not work retroactively so i should clean the current situation with duplicates and make further check for the new uploads

@alextran1502
Copy link
Contributor

FYI, new upload won't run into problem with duplication since we have the checking mechanism in place. The only edge case is the two identical files with two version, one is compressed and one is original, which will cause the duplication.

@joeShuff
Copy link

I'm also seeing some duplicate data after an initial upload via googlephotos takeout, then syncing my device photos. Guessing thats likely the edge case you speak of @alextran1502?

@alextran1502
Copy link
Contributor

I'm also seeing some duplicate data after an initial upload via googlephotos takeout, then syncing my device photos. Guessing thats likely the edge case you speak of @alextran1502?

@joeShuff if the file is compressed then we will see the duplication since the hash value is different with the uncompressed file

@Robin-Sch
Copy link

Robin-Sch commented Dec 29, 2022

In the android app it shows duplicated files, on the web app it doesn't, after logging out and in again and re-uploading.

For example, if I go to the date 26 nov on the android app, it shows 6 pictures, 3 unique and 3 duplicated. If I go to the date 26 nov on my computer, it shows 3 picutres, 3 unique and 0 duplicated.

After closing and re-opening the app this got fixed, but if I didn't close the app it stayed "duplicated".

@jrasm91
Copy link
Contributor

jrasm91 commented Dec 29, 2022

It's worth noting too, that the sha1 hash is only unique per user.

@Robin-Sch
Copy link

In the android app it shows duplicated files, on the web app it doesn't, after logging out and in again and re-uploading.

For example, if I go to the date 26 nov on the android app, it shows 6 pictures, 3 unique and 3 duplicated. If I go to the date 26 nov on my computer, it shows 3 picutres, 3 unique and 0 duplicated.

After closing and re-opening the app this got fixed, but if I didn't close the app it stayed "duplicated".

Also I just noticed another problem, the "Backup up photo's and video's" counter is 0 (because the photo's and video's are already uploaded ig?)

@alextran1502
Copy link
Contributor

In the android app it shows duplicated files, on the web app it doesn't, after logging out and in again and re-uploading.

For example, if I go to the date 26 nov on the android app, it shows 6 pictures, 3 unique and 3 duplicated. If I go to the date 26 nov on my computer, it shows 3 picutres, 3 unique and 0 duplicated.

After closing and re-opening the app this got fixed, but if I didn't close the app it stayed "duplicated".

This might be the state glitch when uploading and updating the timeline. I noticed that sometime the websocket doesn't close properly lead to two uploading events triggered and showing duplication. If closing and reopening the app fix it, this is just cosmetic bug and we will get to it sometimes in the future

@alextran1502
Copy link
Contributor

In the android app it shows duplicated files, on the web app it doesn't, after logging out and in again and re-uploading.

For example, if I go to the date 26 nov on the android app, it shows 6 pictures, 3 unique and 3 duplicated. If I go to the date 26 nov on my computer, it shows 3 picutres, 3 unique and 0 duplicated.

After closing and re-opening the app this got fixed, but if I didn't close the app it stayed "duplicated".

Also I just noticed another problem, the "Backup up photo's and video's" counter is 0 (because the photo's and video's are already uploaded ig?)

If this is not correct, please open a separate issue and provide the steps you have taken to arrive at the problem. I am not sure which operations were done and what is the expectation outcome from your brief report

@immich-app immich-app locked and limited conversation to collaborators Feb 8, 2023
@alextran1502 alextran1502 converted this issue into discussion #1666 Feb 8, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature needs triage Bug that needs triage from maintainer
Projects
None yet
Development

No branches or pull requests

6 participants