Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video/mpeg - supported extensions #8393

Closed
1 of 3 tasks
mmomjian opened this issue Mar 30, 2024 · 2 comments · Fixed by #8400
Closed
1 of 3 tasks

video/mpeg - supported extensions #8393

mmomjian opened this issue Mar 30, 2024 · 2 comments · Fixed by #8400
Labels
format File format support

Comments

@mmomjian
Copy link
Contributor

mmomjian commented Mar 30, 2024

The bug

According to the source, Immich only allows the .MPG extension for the video/mpeg MIME type. According to Wikipedia, there a number of other extensions that are often used for MPEG, but .MPEG is a very commonly used one that Immich doesn't seem to support. If the fix is as simple as adding '.mpeg': ['video/mpeg'], to mime-types.ts, I'm happy to open a PR, but I am not sure where else this is referenced / used. We could also add .MPE, to mimic the support for JPEG (.jpg, .jpeg, .jpe).

The OS that Immich Server is running on

N/A

Version of Immich Server

N/A

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

@mmomjian mmomjian added the format File format support label Mar 30, 2024
@mmomjian mmomjian changed the title image/mpeg - supported extensions video/mpeg - supported extensions Mar 30, 2024
@mmomjian
Copy link
Contributor Author

mmomjian commented Mar 30, 2024

Similar issue, but .3gpp is a supported extension for video/3gpp that Immich does not currently support.

@jrasm91
Copy link
Contributor

jrasm91 commented Mar 31, 2024

Feel free to open a PR. There should only be one place where extensions are listed. Well that and the spec file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format File format support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants