BUG: Search bar doesn't autofocus when adding photos to album.

[halphalp]

The bug

i'm not sure how recently this started happening, but when selecting photos to add to an album, the search bar doesn't auto-focus. i keep accidentally stacking multiple photos when trying to add them to an album because i start typing after clicking 'add'.

The OS that Immich Server is running on

Docker

Version of Immich Server

v1.101.0

Version of Immich Mobile App

v1.101.0

Platform with the issue

• Server
• Web
• Mobile

Your docker-compose.yml content

same as provided

Your .env content

same as provided

Reproduction steps

1. Select multiple photos
2. Click + sign
3. Click add to album
4. Note that the search bar doesn't autofocus

Relevant log output

No response

Additional information

No response

[ben-basten]

For some background - I recently removed this autofocus functionality in this PR. All modals now automatically move focus to the first focusable element, which is the close button in the top right instead of the input field in this case. The reasoning behind the change is to make modal usage predictable, and prevent the keyboard from unexpectedly popping up on mobile devices.

Open to conversation about the best solution here? Maybe the asset viewer keyboard shortcuts shouldn't trigger when a modal is open?

[halphalp]

For some background - I recently removed this autofocus functionality in this PR. All modals now automatically move focus to the first focusable element, which is the close button in the top right instead of the input field in this case. The reasoning behind the change is to make modal usage predictable, and prevent the keyboard from unexpectedly popping up on mobile devices.

Open to conversation about the best solution here? Maybe the asset viewer keyboard shortcuts shouldn't trigger when a modal is open?

i'm not opposed to relearning my ways, but maybe the team could disable functionality unrelated to adding photos to albums when the 'add to album' window is present? i'm not even sure what the keyboard shortcut is for stacking photos, but i apparently keep hitting it when attempting to type my album names.

[ben-basten]

i'm not even sure what the keyboard shortcut is for stacking photos, but i apparently keep hitting it when attempting to type my album names.

Yeah, the shortcut is "s" so it would be easy to unintentionally stack some photos! Looks to me like this is a similar issue to #8804.