Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing photos / faces are not associated with a person during the creation of a person. #9579

Closed
1 of 3 tasks
esclear opened this issue May 18, 2024 · 0 comments
Closed
1 of 3 tasks

Comments

@esclear
Copy link

esclear commented May 18, 2024

The bug

I'm raising this as a bug, as this behavior is, in my opinion unexpected. It tripped me up, at least:

When the person service creates a new person upon reaching the minFaces threshold (currently 3), only the newest (minFaces-th) face and thus picture is associated with the newly created person.

This leads to cases where there are more than minFaces present for a person, but the first minFaces-1 pictures that person is visible on are not associated to that person.

When running the face detection / face recognition tasks manually for missing images, the older pictures are also assigned to the person, but that requires manual intervention by an instance admin.

The OS that Immich Server is running on

Official Docker container

Version of Immich Server

v1.105.1

Version of Immich Mobile App

n/a

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

n/a

Your .env content

n/a

Reproduction steps

1. Upload two images of a new person (that doesn't have any faces present in Immich yet)
2. Observe that none of the images has assigned a person and that no person was created yet
3. Upload a third image (the person service will create a new person)
4. Check the newly created person and the images: Only the third one image is associated with the person.

Relevant log output

No response

Additional information

I'm not familiar with the Immich code base, but the fix could be as simple as using the (up to minFaces) matches in the already present pictures and assigning them to the person during creation of the new person.

@esclear esclear changed the title Existing photos / faces are not associated to a person during the creation of a person. Existing photos / faces are not associated with a person during the creation of a person. May 18, 2024
@immich-app immich-app locked and limited conversation to collaborators May 18, 2024
@mertalev mertalev converted this issue into discussion #9580 May 18, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant