Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txtn date error checking doesn't reset correctly #172

Open
tonybranfort opened this issue Jan 16, 2018 · 1 comment
Open

Txtn date error checking doesn't reset correctly #172

tonybranfort opened this issue Jan 16, 2018 · 1 comment

Comments

@tonybranfort
Copy link
Collaborator

tonybranfort commented Jan 16, 2018

Follow these steps (note this issue does not seem to have any affect - adverse or otherwise - on any data saved - only about what's displayed) :

  1. Edit a transaction date on a client to enter a new valid date (should go back to read mode with new date value - works as expected)
  2. Edit that same date and enter an invalid date - such as deleting the month (should go back to read mode with the pre-edit value - works as expected)
  3. Again edit that same date. The date in the edit will be missing and there will be an error in the console. This is not expected - should show the correct date
@tonybranfort
Copy link
Collaborator Author

tonybranfort commented Jan 16, 2018

This is due to the txtnDate not being converted from string to date after a change; ie, txtnDate is not caught with the changeService.setNewValueViewWithFns(). These need to go through the new dObj.setViewFns. But setViewFns needs to be able to handle paths within arrays (eg clients txtns...txtndDate).

@tonybranfort tonybranfort added this to the v2.12 milestone Jan 30, 2018
@tonybranfort tonybranfort modified the milestones: v2.12, v2.13, v2.14 Mar 3, 2018
@tonybranfort tonybranfort modified the milestones: v2.14, v2.15 Mar 14, 2018
@tonybranfort tonybranfort modified the milestones: v2.15, v2.16 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant