Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isAbsoluteURL regex doesn't work like expected #54

Closed
PoissonBallon opened this issue Jul 4, 2022 · 2 comments
Closed

isAbsoluteURL regex doesn't work like expected #54

PoissonBallon opened this issue Jul 4, 2022 · 2 comments
Assignees
@malcommac
Labels
bug Something isn't working enhancement New feature or request
Milestone
1.6.0

Comments

@PoissonBallon
Copy link
Contributor

Bug Report

Q A
BC Break no
Version 1.52

Summary

isAbsoluteURL regex doesn't work like expected

Current behavior

Impossible to add urlComponents.queryItems coz path is absolute :/

How to reproduce

/connect/login is an absolute URL
connect/login is an absolute URL

Expected behavior

/connect/login is not an absolute URL
connect/login is not an absolute URL

I think error is the ? after the first group in the regex
@malcommac
Copy link
Collaborator

Thank you for your report, I've added a new regular expression validated using NSRegularExpression and several tests.

@malcommac malcommac added this to the 1.6.0 milestone Jul 22, 2022
@malcommac malcommac added bug Something isn't working enhancement New feature or request labels Jul 22, 2022
@malcommac malcommac self-assigned this Jul 22, 2022
@PoissonBallon
Copy link
Contributor Author

Thanks for your awesome works !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcommac malcommac

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@malcommac @PoissonBallon