Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many waitForStatusRecordUnlock crash, thread lock #57

Closed
PoissonBallon opened this issue Jul 26, 2022 · 2 comments
Closed

Many waitForStatusRecordUnlock crash, thread lock #57

PoissonBallon opened this issue Jul 26, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@PoissonBallon
Copy link
Contributor

Bug Report

Q A
BC Break no
Version 1.6.2

Summary

We have many (but intermittent) waitForStatusRecordUnlock crash and we doesn't know why,

Do you have any idea ? Misuse of the HTTPClient ?

Thanks for ur helping,

Screenshot 2022-07-26 at 17 14 44

@PoissonBallon PoissonBallon changed the title Many waitForStatusRecordUnlock, thread lock ? Many waitForStatusRecordUnlock crash, thread lock ? Jul 26, 2022
@malcommac
Copy link
Collaborator

Did you have a replicable project?
I'm looking at the code and I think we can avoid the async operation of serialization just because it's already inside the async fetch() operation.

Moreover, looking on swift forums I've also seen it could be a compiler error fixed in Swift 5.7.

@malcommac malcommac reopened this Aug 15, 2022
@malcommac
Copy link
Collaborator

I've removed the async in serializeData() of the HTTPSerializableBody protocol used to serialize body content of each request.

@malcommac malcommac added the bug Something isn't working label Aug 15, 2022
@malcommac malcommac self-assigned this Aug 15, 2022
@malcommac malcommac added this to the 1.7.0 milestone Aug 15, 2022
@malcommac malcommac changed the title Many waitForStatusRecordUnlock crash, thread lock ? Many waitForStatusRecordUnlock crash, thread lock Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants