Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do I need fastify-sentry if I am using @sentry/opentelemetry? #685

Closed
gajus opened this issue Jan 22, 2024 · 1 comment
Closed

Do I need fastify-sentry if I am using @sentry/opentelemetry? #685

gajus opened this issue Jan 22, 2024 · 1 comment

Comments

@gajus
Copy link

gajus commented Jan 22, 2024

I am not clear whether fastify-sentry is needed if I am already using @sentry/opentelemetry, and my goal is to just capture performance traces. As far as I understand, @opentelemetry/auto-instrumentations-node already handles instrumentation for us.

@gajus
Copy link
Author

gajus commented Jan 22, 2024

Hey @md384 this is intentional! When you set instrumenter: 'otel' to be the configuration in your Sentry.init, we expect you to use the otel APIs to create/read span, and not rely on startTransaction or getTransaction.

getsentry/sentry-javascript#7985 (comment)

Since this package uses startTransaction, it means we should not be using it.

@gajus gajus closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant