Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

fix: rename MigratioLog.swift to MigrationLog.swift #33

Closed

Conversation

danydev
Copy link

@danydev danydev commented May 25, 2020

Description

Just fix typo in file MigratioLog.swift that should really be MigrationLog.swift

This PR tackles:

  • fixed the name of the file to the intended one.

Checklist

  • I have followed the indications in the CONTRIBUTING.
  • The documentation related to the proposed change has been updated accordingly (plus comments in code).
  • I have written new tests for my core changes, as applicable.
  • I have successfully run tests with my changes locally.
  • It is ready for review! 🚀

Fixes

@ImmuniDGR
Copy link

🚔 Safety Check 🚔

🔰 Result 🔰

✅ All configuration files are in line with the master branch.

🛠 Diagnostic information 🛠

  • CircleCI scheduler pipeline: Update Readme #141 (id: 9c301ffe-9d4c-4e7c-8321-c655fda897b4)
  • Last verified commit: #5124abde4d5f4d8599ea3f8f5a5c87ed9a6573bd
  • Time of check: 25/05/2020, 18:45:52 UTC
  • The following protected files have been checked for changes: yarn.lock, fastlane/Fastfile, publiccode.yml, CI/danger/commitlint/rules.ts, fastlane/Appfile, package.json, Podfile, .gitmodules, Makefile, project_debug.yml, CI/Export/app-store.plist, swiftgen.yml, scheduler_config.json, CI/danger/swiftlint.ts, .swiftformat, dangerfile.ts, CI/danger/swiftformat.ts, Brewfile, Podfile.lock, project.yml, CI/changelog_config.tpl, CI/danger/commitlint/index.ts, CI/Export/development.plist, CI/danger/utils.ts, .swiftlint.yml, CI/danger/danger.ts.

@danydev
Copy link
Author

danydev commented May 25, 2020

Two minor things I noticed in the process:

  • Github template (above) has a wrong CONTRIBUTING url.
  • CONTRIBUTING "Gitflow" section refers to a development branch that actually is not present in the repo. You may want to either use a development branch or just update the contributing readme.

@bolismauro
Copy link
Contributor

Hi! Thanks!
I'll open a PR :)

@danydev
Copy link
Author

danydev commented May 26, 2020

@bolismauro cool!

@bolismauro bolismauro changed the base branch from master to development May 28, 2020 07:44
@danydev
Copy link
Author

danydev commented Jun 1, 2020

@bolismauro @LorDisturbia do we need something else to get it merged?

@danydev
Copy link
Author

danydev commented Jun 8, 2020

@bolismauro @LorDisturbia pinging again.

@bolismauro
Copy link
Contributor

All good from us. We need to wait @immuniopensource for the merge :)

@danydev
Copy link
Author

danydev commented Jul 1, 2020

@immuniopensource any objection?

@danydev
Copy link
Author

danydev commented Aug 5, 2020

@immuniopensource can you tell us what's blocking you to merge?

@valerio-castelli valerio-castelli force-pushed the development branch 6 times, most recently from b7265de to 127ed5b Compare October 5, 2021 07:35
@stale
Copy link

stale bot commented Dec 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 30, 2021
@stale stale bot closed this Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GENERAL] Fix MigratioLog.swift file name
3 participants