New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takeLast(0) should return an empty collection #1245

Closed

jmzhang opened this issue Jun 8, 2017 · 1 comment

Labels

bug

jmzhang commented Jun 8, 2017

Calling takeLast(0) on a collection should return an empty collection, rather than a full copy of the collection, as given in the implementation here https://github.com/facebook/immutable-js/blob/master/src/CollectionImpl.js#L511

kozlitinaelja added the bug label

Collaborator

leebyron commented Sep 29, 2017

Good ol' -0. Thanks for the report!

leebyron closed this as completed in

e689900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment