New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SMR-979] Royalty Enforcement #24
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
test/royalty-enforcement/WhitelistERC721TransfersApprovals.test.ts
Outdated
Show resolved
Hide resolved
test/royalty-enforcement/WhitelistERC721TransfersApprovals.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of my own comments are blocking, but this is IMO:
So if I move my assets to a smart contract wallet that's not whitelisted, I may never be able to sell them?
https://immutable.atlassian.net/browse/SMR-979
PR adds royalty enforcement to the ERC721 Preset contract.
Added:
RoyaltyWhitelist.sol
: whitelist registry that allows for whitelisting of addresses and bytecodeEIP2981
andWhitelistRegistry
toImmutableERC721Base
RoyaltyWhitelist.test.ts
: tests for whitelist registryWhitelistERC721TransfersApprovals
: tests for ERC721 transfers and approvals with whitelistImmutableERC721PermissionedMintable.test
to include e2e enforced royalty trade flowutils.ts