Generation of default interface attributes was fixed #104

+ make value attribute on annotations in absence of mandatory attributes
to be constructor parameter
+ improved validation of Value.Derived and Value.Default

+ so added Value source to value module so you can javadoc and have
sources and while you building a release

value-fixture/src/org/immutables/fixture/IfaceValue.java

@@ -26,4 +26,10 @@ public interface IfaceValue {
 
   @Value.Auxiliary
   List<String> auxiliary();
+
+  @Value.Auxiliary
+  @Value.Derived
+  default int get() {
+    return getNumber() + auxiliary().size();
+  }
 }

value-fixture/src/org/immutables/fixture/annotation/An.java

@@ -26,6 +26,13 @@
   String otherValue();
 }
 
+@Value.Immutable
+@interface HasDefault {
+  int value();
+
+  String otherValue() default "";
+}
+
 @Retention(RetentionPolicy.RUNTIME)
 @Value.Immutable
 @interface An {
@@ -38,5 +45,5 @@
 @Retention(RetentionPolicy.SOURCE)
 @Value.Immutable
 @interface Be {
-  Class<? extends Number>[] cl() default {Integer.class};
+  Class<? extends Number>[] cl() default {Integer.class, Double.class};
 }

value-fixture/test/org/immutables/fixture/annotation/AnnotationTest.java

@@ -22,8 +22,7 @@
 public class AnnotationTest {
 
   @Test
-  public void testName() {
-
+  public void ann() {
     An runtime = getClass().getAnnotation(An.class);
     An immutable = ImmutableAn.of(13);
 
@@ -34,4 +33,13 @@ public void testName() {
 
     check(immutable.bees()).isOf(runtime.bees());
   }
+
+  @Test
+  public void bee() {
+    ImmutableHasDefault.of(1).withOtherValue("w");
+
+    check(ImmutableBe.builder().build()).is(ImmutableBe.builder()
+        .cl(Integer.class, Double.class)
+        .build());
+  }
 }

value-processor/src/org/immutables/value/processor/meta/AccessorAttributesCollector.java

@@ -195,23 +195,40 @@ private void processGenerationCandidateMethod(ExecutableElement attributeMethodC
 
       if (isAbstract) {
         attribute.isGenerateAbstract = true;
+
         if (attributeMethodCandidate.getDefaultValue() != null) {
           attribute.isGenerateDefault = true;
-        } else if (defaultAnnotationPresent) {
-          report(attributeMethodCandidate)
-              .annotationNamed(DefaultMirror.simpleName())
-              .error("@Value.Default should have initializer body", name);
-        } else if (derivedAnnotationPresent) {
-          report(attributeMethodCandidate)
-              .annotationNamed(DerivedMirror.simpleName())
-              .error("@Value.Derived should have initializer body", name);
+        }
+
+        if (defaultAnnotationPresent || derivedAnnotationPresent) {
+          if (defaultAnnotationPresent) {
+            if (attribute.isGenerateDefault) {
+              report(attributeMethodCandidate)
+                  .annotationNamed(DefaultMirror.simpleName())
+                  .warning("@Value.Default annotation is superflous for default annotation attribute");
+            } else {
+              report(attributeMethodCandidate)
+                  .annotationNamed(DefaultMirror.simpleName())
+                  .error("@Value.Default attibute should have initializer body", name);
+            }
+          }
+          if (derivedAnnotationPresent) {
+            if (attribute.isGenerateDefault) {
+              report(attributeMethodCandidate)
+                  .annotationNamed(DerivedMirror.simpleName())
+                  .error("@Value.Derived cannot be used with default annotation attribute");
+            } else {
+              report(attributeMethodCandidate)
+                  .annotationNamed(DerivedMirror.simpleName())
+                  .error("@Value.Derived attibute should have initializer body", name);
+            }
+          }
         }
       } else if (defaultAnnotationPresent && derivedAnnotationPresent) {
         report(attributeMethodCandidate)
             .annotationNamed(DerivedMirror.simpleName())
             .error("Attribute '%s' cannot be both @Value.Default and @Value.Derived", name);
         attribute.isGenerateDefault = true;
-        attribute.isGenerateDerived = false;
       } else if ((defaultAnnotationPresent || derivedAnnotationPresent) && isFinal) {
         report(attributeMethodCandidate)
             .error("Annotated attribute '%s' will be overriden and cannot be final", name);

value-processor/src/org/immutables/value/processor/meta/ValueAttribute.java

@@ -55,6 +55,7 @@ public final class ValueAttribute extends TypeIntrospectionBase {
 
   private static final String GUAVA_IMMUTABLE_PREFIX = UnshadeGuava.typeString("collect.Immutable");
   private static final String NULLABLE_SIMPLE_NAME = "Nullable";
+  private static final String VALUE_ATTRIBUTE_NAME = "value";
   private static final String ID_ATTRIBUTE_NAME = "_id";
 
   public AttributeNames names;
@@ -132,6 +133,7 @@ public boolean requiresAlternativeStrictConstructor() {
 
   public boolean isMandatory() {
     return isGenerateAbstract
+        && !isGenerateDefault // is the case for defaulted abstract annotation attribute
         && !isContainerType()
         && !isNullable()
         && !hasBuilderSwitcherDefault();
@@ -650,10 +652,24 @@ int getConstructorParameterOrder() {
       constructorOrder = parameter.isPresent()
           ? parameter.get().order()
           : -1;
+
+      if (containingType.isAnnotationType() && names.get.equals(VALUE_ATTRIBUTE_NAME)) {
+        constructorOrder = thereNoOtherMandatoryAttributes() ? 0 : -1;
+      }
     }
     return constructorOrder;
   }
 
+  private boolean thereNoOtherMandatoryAttributes() {
+    List<ValueAttribute> mandatories = containingType.getMandatoryAttributes();
+    for (ValueAttribute m : mandatories) {
+      if (m != this) {
+        return false;
+      }
+    }
+    return true;
+  }
+
   public boolean isConstructorParameter() {
     return getConstructorParameterOrder() >= 0;
   }
@@ -732,7 +748,7 @@ private void makeRegularIfDefaultWithValidation() {
 
   private void makeRegularIfContainsWildcards() {
     // I hope this check isn't too simplistic
-    if (returnTypeName.indexOf('?') >= 0) {
+    if (returnTypeName.indexOf('?') >= 0 && typeKind != AttributeTypeKind.ARRAY) {
       typeKind = AttributeTypeKind.REGULAR;
     }
   }

value/pom.xml

@@ -16,11 +16,13 @@
   <artifactId>value</artifactId>
 
   <dependencies>
+<!--
     <dependency>
       <groupId>org.immutables</groupId>
       <artifactId>value-annotations</artifactId>
       <version>${project.version}</version>
     </dependency>
+ -->
     <dependency>
       <groupId>org.immutables</groupId>
       <artifactId>value-processor</artifactId>
@@ -56,7 +58,9 @@
               <artifactSet>
                 <includes>
                   <include>org.immutables:value</include>
+<!--              
                   <include>org.immutables:value-annotations</include>
+ -->
                   <include>org.immutables:value-processor</include>
                   <include>org.immutables:generator</include>
                   <include>com.google.guava:guava</include>
@@ -83,12 +87,14 @@
               </relocations>
 
               <filters>
+<!--
                 <filter>
                   <artifact>org.immutables:value-annotations</artifact>
                   <includes>
                     <include>**</include>
                   </includes>
                 </filter>
+ -->
                 <filter>
                   <artifact>org.immutables:value-processor</artifact>
                   <includes>