Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile install need fix #19

Closed
ulfhanebutte opened this issue Aug 12, 2016 · 1 comment
Closed

Makefile install need fix #19

ulfhanebutte opened this issue Aug 12, 2016 · 1 comment

Comments

@ulfhanebutte
Copy link

to properly create the lib and include directory and copy the files over, the Makefile needs to be fixed
PREFIX needs to be in brackets and directory need to be made if non existing.

here is the fix:
install: all
@mkdir -p $(PREFIX)
@mkdir -p $(PREFIX)/lib
@mkdir -p $(PREFIX)/include
install src/libpcg_random.a $(PREFIX)/lib/.
install -m 0644 include/pcg_variants.h $(PREFIX)/include/.

@imneme
Copy link
Owner

imneme commented May 25, 2019

I agree about the parens, but I don't think it's unreasonable to assume that the library directory should exist. I'm reluctant to run mkdir for the library directory because it's not clear what the right permissions for it would be.

@imneme imneme closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants