Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT] Types are broken v4.0.3 #1571

Closed
PabloSzx opened this issue May 17, 2021 · 8 comments
Closed

[IMPORTANT] Types are broken v4.0.3 #1571

PabloSzx opened this issue May 17, 2021 · 8 comments
Labels

Comments

@PabloSzx
Copy link
Collaborator

PabloSzx commented May 17, 2021

image

image

image

@imolorhe

@open-collective-bot
Copy link

Hey @PabloSzx 👋,

Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little help counts!

@PabloSzx PabloSzx changed the title [IMPORTANT] Types are broken [IMPORTANT] Types are broken v4.0.3 May 17, 2021
@imolorhe
Copy link
Collaborator

Thanks. I expected it to not be required but I was wrong. I'll publish the types package then.

@imolorhe
Copy link
Collaborator

Could you try again? I published the altair-exported-types package

@imolorhe imolorhe added the bug label May 17, 2021
@imolorhe
Copy link
Collaborator

Let me know if it works since altair-exported-types is still marked as a dev dependency in altair-static (so might not work, not sure). If not, I'll have to release v4.0.4 with altair-exported-types as a direct dependency.

@PabloSzx
Copy link
Collaborator Author

If I install manually "altair-exported-types" the publish fixed it, but If I remove it the error is still there

@imolorhe
Copy link
Collaborator

So it needs to be made a direct dependency then.

@imolorhe
Copy link
Collaborator

v4.0.4 has been released.

@PabloSzx
Copy link
Collaborator Author

v4.0.4 has been released.

thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants