Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button nested inside of link #141

Open
BNewing opened this issue Oct 29, 2019 · 0 comments
Open

Button nested inside of link #141

BNewing opened this issue Oct 29, 2019 · 0 comments

Comments

@BNewing
Copy link
Contributor

BNewing commented Oct 29, 2019

At the moment, there are a few instances of <button> elements being inside of an <a> tag. For example, the 'Learn how you can help' on the home page:

image

As this links to another section further down the page, semantically it could do with being just a link. The button styles could be moved to the link, and the appearance preserved.

A benefit of doing this would be fixing slightly unusual keyboard focus behaviour. Because there are two interactive elements - both the 'and the`, you have to tab twice to get past the element. It would also be a better experience for screen reader users.

I'm new to this project and not yet in the slack, but I'd be happy to put together a PR if it's welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant