Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Add knock check/confirmation and retry #18

Open
RastaTaz opened this issue Apr 11, 2021 · 3 comments
Open

[Enhancement] - Add knock check/confirmation and retry #18

RastaTaz opened this issue Apr 11, 2021 · 3 comments

Comments

@RastaTaz
Copy link

Seen in another android app:

  • Add knock confirmation by reaching a TCP port after the knock sequence
  • Replay knock sequence (add a count limit) in case confirmation is not OK
@impalex
Copy link
Owner

impalex commented Apr 11, 2021

What do you mean by "confirmation"?

@RastaTaz
Copy link
Author

I use a knock sequence containing some UDP packets : but UDP don't always go through in due time or due sequence, especially in crowded areas. So I sometimes have to launch knock sequence several times...

As the goal of a port knock is often to temporary white list an IP on a firewall : an optional check done by the port knocking application could confirm knock was successful.
=> It could be achieved by trying to connect to a TCP port of a hosted service behind the firewall, either:

  • though a NAT when using IPv4 (re-using the target IP of the knock sequence)
  • on another IP of the same subnet when using IPv6 (as there's no NAT on IPv6)

Then if confirmation is not OK, a replay of the knocking sequence should be done again.

  • a "retry limit" may also prevent from having infinite retries

As an example, see project https://github.com/DJAndries/portknocker-android : it contains such a feature.

I hope the above makes sense to you...

@impalex
Copy link
Owner

impalex commented Apr 12, 2021

Thanks for the explanation.
TBH I don't really like this concept. We'll see... Low priority atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants