Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports pagination issue #503

Closed
chavda-bhavik opened this issue Feb 14, 2024 · 0 comments · Fixed by #505
Closed

Imports pagination issue #503

chavda-bhavik opened this issue Feb 14, 2024 · 0 comments · Fixed by #505
Labels
bug Something isn't working citical Needs to be fixed in urgent basis good first issue Good for newcomers

Comments

@chavda-bhavik
Copy link
Collaborator

Describe the bug
When the user changes items on a par page and the user is on a page that is out of context for the new page size. The imports page shows empty imports.

To Reproduce
Steps to reproduce the behavior:

  1. Create more than 50 imports.
  2. Keep per page records size 10 and go to the last page of imports.
  3. Switch per page records size to 50.
  4. See the empty imports page

Expected behavior
When a user tries navigating among sizes of the imports page, if the current page number is within the context of the new page size then keep it else switch the page to the last page of the new page size.

Screenshots
https://github.com/implerhq/impler.io/assets/50201755/cb18c549-02e3-4074-8e3c-d6b528dcf911

@chavda-bhavik chavda-bhavik added bug Something isn't working good first issue Good for newcomers citical Needs to be fixed in urgent basis labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working citical Needs to be fixed in urgent basis good first issue Good for newcomers
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant