Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use with eslint-plugin-i #253

Closed
csantos1113 opened this issue Nov 15, 2023 · 2 comments · May be fixed by #283
Closed

Cannot use with eslint-plugin-i #253

csantos1113 opened this issue Nov 15, 2023 · 2 comments · May be fixed by #283

Comments

@csantos1113
Copy link

I always want "faster speed" and was hyped when I saw this in your README.md

This plugin adds TypeScript support to eslint-plugin-import (Or maybe you want to try eslint-plugin-i for faster speed)

But I was pulled down of my excitement because there is a required peerDependency for eslint-plugin-import that doesn't let me swap 😞

"eslint-plugin-import": "*"

Would it be possible to make these 2 optional peerDependencies instead? 🙏

@JounQin
Copy link
Collaborator

JounQin commented Nov 16, 2023

It's clearly documented that you should use alias on installation.

npm install -D eslint-plugin-import@npm:eslint-plugin-i@latest

See also #248

@JounQin JounQin closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
@jrnail23
Copy link

jrnail23 commented May 9, 2024

FYI, that clearly documented fix is incorrectly documented:

https://github.com/import-js/eslint-import-resolver-typescript/blob/master/README.md?plain=1#L61

Important when using eslint-plugin-i and npm: Use npm i -D eslint-plugin-import@eslint-plugin-i@latest eslint-import-resolver-typescript, or you will end up with both eslint-plugin-import and eslint-plugin-i in your node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants