import/no-cycle and flow type imports

[goodmind]

Flow import type doesn't have cycles. How to ignore them?

[gajus]

@ljharb I can submit a PR for this.

Does this need to be a configurable option or default behaviour?

[ljharb]

@gajus I think it can be the default, since there seems to be no value in checking them.

[gajus]

Is that it or am I overlooking something?

#1126

[Hypnosphi]

Flow import type doesn't have cycles

@goodmind Sorry, but what did you mean by that?

[Hypnosphi]

there seems to be no value in checking them

@ljharb I don't think that's true, see facebook/flow@e6a10b1

Dependency cycles can be bad for Flow performance

See also facebook/flow@d7e7e78 which specifically focuses on type imports

I think there should at least be an option to check type imports with no-cycle

[ljharb]

@Hypnosphi an option to enable this checking seems fine to me as well. @goodmind's OP implied there were no cycles; your link seems to successfully dispute this - so perhaps it'd indeed be better to restore this checking by default, with an option to disable it? Not really sure.