Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package has memo-parser's node_modules bundled #1635

Closed
gorner opened this issue Jan 29, 2020 · 4 comments
Closed

NPM package has memo-parser's node_modules bundled #1635

gorner opened this issue Jan 29, 2020 · 4 comments

Comments

@gorner
Copy link

gorner commented Jan 29, 2020

While reviewing the latest changes to this package, I noticed that the latest packaged version of this module on NPM appears to (now) include a bunch of files under memo-parser/node_modules, as shown here: https://diff.intrinsic.com/eslint-plugin-import/2.19.1/2.20.0

I expect fixing this would simply require adding this path to .gitignore (in the absence of a .npmignore). I see "node_modules" is already there, perhaps NPM is processing this as the top level directory only.

@ljharb
Copy link
Member

ljharb commented Jan 29, 2020

Hmm - memo-parser/node_modules is already gitignored, so it should be automatically npmignored. This might be an npm bug.

@ljharb
Copy link
Member

ljharb commented Jan 29, 2020

ah nvm, turns out this package is unfortunately using the dangerous files field, without excluding nested node_modules. I'll fix this for the next release.

@ljharb ljharb closed this as completed in aff3a46 Jan 29, 2020
@benmosher
Copy link
Member

@ljharb FWIW, I think the memo-parser can be EOL'd. doesn't make as much perf difference as it did originally.

@ljharb
Copy link
Member

ljharb commented Jan 30, 2020

That’s fine also; it’s never been published that i can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants