Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic-import-chunkname doesn't work with latest babel-eslint #1771

Closed
Hypnosphi opened this issue May 20, 2020 · 2 comments · Fixed by #1833
Closed

dynamic-import-chunkname doesn't work with latest babel-eslint #1771

Hypnosphi opened this issue May 20, 2020 · 2 comments · Fixed by #1833
Labels
help wanted

Comments

@Hypnosphi
Copy link
Contributor

That's because it traverses CallExpressions while import() is now an ImportExpression:
babel/babel#10828
@ljharb
Copy link
Member

ljharb commented May 20, 2020

We’ll need to be sure to support both.

@noelebrun
Copy link
Contributor

It seems like there's the same issue with @typescript-eslint/parser. I guess that's for the same reason.

@noelebrun noelebrun mentioned this issue Jun 20, 2020
Merged
@ljharb ljharb closed this as completed in 4d6c539 Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] dynamic-import-chunkname/TypeScript: support @typescript-eslint/parser
3 participants
@ljharb @Hypnosphi @noelebrun