Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json5 security issue #2630

Closed
1000i100 opened this issue Dec 31, 2022 · 3 comments
Closed

json5 security issue #2630

1000i100 opened this issue Dec 31, 2022 · 3 comments

Comments

@1000i100
Copy link

# npm audit report

json5  <2.2.2
Severity: high
Prototype Pollution in JSON5 via Parse Method - https://github.com/advisories/GHSA-9c47-m6qq-7p4h
fix available via `npm audit fix --force`
Will install xo@0.44.0, which is a breaking change
node_modules/json5
node_modules/tsconfig-paths/node_modules/json5
  tsconfig-paths  3.5.0 - 3.9.0 || 3.11.0 - 3.14.1
  Depends on vulnerable versions of json5
  node_modules/tsconfig-paths
    eslint-plugin-import  >=2.24.2
    Depends on vulnerable versions of tsconfig-paths
    node_modules/eslint-plugin-import
      xo  >=0.45.0
      Depends on vulnerable versions of eslint-plugin-import
      node_modules/xo

4 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force
@1000i100
Copy link
Author

Next tsconfig-paths version will fix it : dividab/tsconfig-paths#233

@ljharb
Copy link
Member

ljharb commented Dec 31, 2022

json5 v1.0.2 has been published which fixes it. No action needs to be taken in ANY other package.

This is also a duplicate of #2628 and #2627.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2022
@ljharb
Copy link
Member

ljharb commented Dec 31, 2022

Additionally, this is not a vulnerability - it's a false positive, and you should just ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants