Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v6: Can't pass null to path module functions #272

Closed
strawbrary opened this issue Apr 25, 2016 · 4 comments
Closed

Node.js v6: Can't pass null to path module functions #272

strawbrary opened this issue Apr 25, 2016 · 4 comments

Comments

@strawbrary
Copy link
Contributor

strawbrary commented Apr 25, 2016

In Node.js v6, all path functions will now throw an error if they receive a non-string path argument. eslint-import-resolver-node returns path: null for core modules which causes fileExistsWithCaseSync to throw an error.

I wasn't sure if it would be better to make the change in the resolver or the plugin itself so I'm just opening an issue about this for now.

@benmosher
Copy link
Member

Oh, wild. Good to know.

We probably ought to go ahead and open a PR with v6 in the Travis config and start getting ready! Thanks!

@benmosher
Copy link
Member

Also, for future reference: the null path from the resolver is part of the spec. The plugin should exit early and not pass it to the path functions.

@strawbrary
Copy link
Contributor Author

Got it, thanks for the info. v6 isn't out officially yet so I'm not sure if there's a way to get Travis to build with it, but they're aiming to release it tomorrow I believe. In the meantime the rc builds are here: https://nodejs.org/download/rc/

@benmosher
Copy link
Member

fixed in #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants