[Fix] newline-after-import: fix exactCount with considerComments false positive, when there is a leading comment
#2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` false positive, when there is a leading comment Fixes import-js#2882.
kinland
force-pushed
the
issue-2882-exact-count-with-consider-comments
branch
2 times, most recently
from
dbd4ad7
to
ef3d0e7
Compare
|
Sorry about the force-pushes... I'm a bit sleep deprived |
|
I found an edge case that I missed... will push a new commit when I figure out how to fix it. |
ljharb
requested changes
Sep 26, 2023
ljharb
approved these changes
Sep 26, 2023
ljharb
force-pushed
the
issue-2882-exact-count-with-consider-comments
branch
from
06e8759
to
66cb10f
Compare
ljharb
changed the title
newline-after-import: fix exactCount with considerComments false positive, when there is a leading comment
|
Thanks a lot! Clearly my one added test wasn't good enough when rebasing the previous PR, sorry. |
Honestly, I can't fault you for that. I didn't consider that a comment before an import would break my code, either. These things get very complex quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2882 and adds additional test cases to cover the combination of
exactCountandconsiderComments