Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-reassign rule fails #29

Closed
chase opened this issue Jun 4, 2015 · 3 comments
Closed

no-reassign rule fails #29

chase opened this issue Jun 4, 2015 · 3 comments
Labels
Milestone

Comments

@chase
Copy link

chase commented Jun 4, 2015

~/project/node_modules/eslint-plugin-import/lib/rules/no-reassign.js:15
    if (locals.has(id.name)) context.report(id, message(id.name))
                     ^
TypeError: Cannot read property 'name' of null
    at checkIdentifier (~/project/node_modules/eslint-plugin-import/lib/rules/no-reassign.js:15:22)
    at EventEmitter.FunctionDeclaration (~/project/node_modules/eslint-plugin-import/lib/rules/no-reassign.js:53:7)
    at EventEmitter.emit (events.js:129:20)
    at Controller.controller.traverse.enter (~/project/node_modules/eslint/lib/eslint.js:725:25)
    at Controller.__execute (~/project/node_modules/eslint/node_modules/estraverse/estraverse.js:393:31)
    at Controller.traverse (~/project/node_modules/eslint/node_modules/estraverse/estraverse.js:491:28)
    at EventEmitter.module.exports.api.verify (~/project/node_modules/eslint/lib/eslint.js:718:24)
    at verify (~/project/node_modules/gulp-eslint/index.js:21:25)
    at DestroyableTransform._transform (~/project/node_modules/gulp-eslint/index.js:44:18)
    at DestroyableTransform.Transform._read (~/project/node_modules/gulp-eslint/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
@benmosher
Copy link
Member

Could you provide the linted code file, or a simplified test case that produces this exception?

I'd like to better understand what is happening before I start slinging code. 😅

@benmosher benmosher added the bug label Jun 5, 2015
@benmosher benmosher added this to the v0.4.5 milestone Jun 5, 2015
@benmosher
Copy link
Member

No worries, found a case that caused it (unnamed function as default export). Fixed. Will release ASAP.

@chase
Copy link
Author

chase commented Jun 5, 2015

Thank you! I apologize for not expanding on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants