no-unresolved not working for require

[mctep]

Hello!
Thank you for your job.

My file:

require('./foo.js');
import './foo.js';

When executing

eslint --no-eslintrc --parser babel-eslint --plugin import --rule '{"import/no-unresolved":2}' test.js

I get only one error for import declaration:

~/test.js
  2:8  error  Unable to resolve path to module './foo.js'  import/no-unresolved

✖ 1 problem (1 error, 0 warnings)

[benmosher]

I'm not sure what you're expecting. The no-unresolved rule only lints import statement paths; it will not inspect require calls.

[benmosher]

Marking this invalid and closing for now, but if I've misunderstood, let me know.

[benmosher]

Actually, upon reflection, this seems like a good improvement on the rule, and it shouldn't be tough to add. 👍

[benmosher]

Agh... on second thought, require is a bit of a different animal, since it's a dynamic CallExpression... I think in the interest of simplicity, I'm going to re-mark this invalid and close. (at least for now... I may start doing more around CommonJS soon.)

[mctep]

Ok. I understand your reasons.

BTW. I has not found any plugin for resolving paths for require calls. So I can write it, but it will use a resolver similar to yours. And I think it will be pretty to add it feature in your module.

Maybe it will be a good decision to add an additional rule like no-unresolved-require.
So, please, look at this commit mctep@acd4b45

[mctep]

And support ArrayExpression for require arguments is not necessary, I think 😄

[benmosher]

You make a strong case. Feels like it should be separate, though... Maybe as a setting?

I'll take another look. 😄

[benmosher]

Check out my PR. I adapted your alternate rule into a commonjs setting.

Why were you supporting require([...]), though? for AMD? or something else? I'm not familiar with an array argument for CommonJS.

[mctep]

Oh. It's great! Thank you very much.

About an array of arguments. Yes it is using for AMD, and it should not be using for CommonJS. I realized it after commit only :-)

[benmosher]

Added support for AMD via amd: true option, too. 😄 Thanks for your persistence!

[mctep]

🍻