Merge pull request #3162 from ravinderk/issues/3161

fix(admin-form): prevent js notice when edit price type setting field #3161
impress-org · May 3, 2018 · 7a852f7 · 7a852f7
2 parents 6df4965 + a4dcee1
commit 7a852f7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/assets/src/js/admin/admin-scripts.js b/assets/src/js/admin/admin-scripts.js
@@ -2964,7 +2964,7 @@ var give_setting_edit = false;
 		$poststuff.on('focusout', 'input.give-money-field, input.give-price-field', function () {
 			price_string = give_unformat_currency($(this).val(), false);
 
-			$(this).giveHintCss( 'hide', {});
+			$(this).giveHintCss( 'hide', {label: give_vars.price_format_guide.trim()});
 
 			// Back out.
 			if (give_unformat_currency('0', false) === give_unformat_currency($(this).val(), false)) {

diff --git a/includes/admin/give-metabox-functions.php b/includes/admin/give-metabox-functions.php
@@ -402,7 +402,7 @@ function give_donation_limit( $field ) {
 					id="<?php echo $field_options['id']; ?>_give_donation_limit_<?php echo $amount_range; ?>"
 					data-range_type="<?php echo esc_attr( $amount_range ); ?>"
 					value="<?php echo esc_attr( $amount ); ?>"
-					placeholder="<?php echo $field_options['options'][ $amount_range ]; ?>"
+					placeholder="<?php echo $field_options['attributes']['placeholder']; ?>"
 				<?php echo give_get_custom_attributes( $field_options ); ?>
 			/>
 			<?php