New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-plugins): display inline notification before updating #2789
Comments
I'm not seeing the warning display within the plugin update message upon testing: @Sidsector9 I'm reopening. Can you recheck this and make sure I've configured the readme properly: https://github.com/WordImpress/Give/blob/master/readme.txt#L388 |
I meant to reopen this yesterday too. Also couldn't get it to show correctly. |
@mathetos I found the issue. @Sidsector9 using hard-coded base directory name instead of dynamic. I found another issue too about logic which I will discuss with @Sidsector9. for ref: https://github.com/WordImpress/Give/blob/master/includes/admin/plugins.php#L280 |
feat(admin-plugins): display inline notification before updating #2789
This issue has been resolved but I am reopening this to test with few examples. I will close this if it will work fine for me. |
@mathetos @DevinWalker working fine for me. |
Issue Overview
When Give has a major update, it would be excellent to give our users additional warnings BEFORE they update. This tutorial walks through how that can be done by creating inline update messages:
https://wisdomplugin.com/add-inline-plugin-update-message
Being able to say "Hey, version X.XX has database updates. Please backup your site first. And read all about the awesome features on this blog post" would be really useful.
The text was updated successfully, but these errors were encountered: