Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-plugins): display inline notification before updating #2789

Closed
mathetos opened this issue Feb 8, 2018 · 5 comments
Closed

feat(admin-plugins): display inline notification before updating #2789

mathetos opened this issue Feb 8, 2018 · 5 comments
Assignees

Comments

@mathetos
Copy link
Member

mathetos commented Feb 8, 2018

Issue Overview

When Give has a major update, it would be excellent to give our users additional warnings BEFORE they update. This tutorial walks through how that can be done by creating inline update messages:
https://wisdomplugin.com/add-inline-plugin-update-message

Being able to say "Hey, version X.XX has database updates. Please backup your site first. And read all about the awesome features on this blog post" would be really useful.

@kevinwhoffman kevinwhoffman changed the title Consider implementing inline update notifications feat(plugin-update): display inline notification before updating Feb 8, 2018
@ravinderk ravinderk added this to the 2.1 milestone Feb 9, 2018
@kevinwhoffman kevinwhoffman changed the title feat(plugin-update): display inline notification before updating feat(update): display inline notification before updating Feb 21, 2018
@DevinWalker DevinWalker removed this from the 2.1 milestone Mar 6, 2018
@DevinWalker DevinWalker added this to the Sprint: 2018/03/28 - 2018/04/10 milestone Apr 11, 2018
@kevinwhoffman kevinwhoffman modified the milestones: Sprint: 2018/03/28 - 2018/04/17, Sprint: 2018/04/18 - 2018/05/01 Apr 17, 2018
@DevinWalker DevinWalker changed the title feat(update): display inline notification before updating feat(admin-plugins): display inline notification before updating May 4, 2018
@DevinWalker
Copy link
Member

I'm not seeing the warning display within the plugin update message upon testing:

2018-05-04_11-02-44

@Sidsector9 I'm reopening. Can you recheck this and make sure I've configured the readme properly: https://github.com/WordImpress/Give/blob/master/readme.txt#L388

@DevinWalker DevinWalker reopened this May 4, 2018
@mathetos
Copy link
Member Author

mathetos commented May 4, 2018

I meant to reopen this yesterday too. Also couldn't get it to show correctly.

@ravinderk
Copy link
Collaborator

ravinderk commented May 7, 2018

@mathetos I found the issue.

@Sidsector9 using hard-coded base directory name instead of dynamic.
in_plugin_update_message-Give/give.php (current) --> in_plugin_update_message-{GIVE_PLUGIN_BASENAME} (recommanded)

I found another issue too about logic which I will discuss with @Sidsector9.

for ref: https://github.com/WordImpress/Give/blob/master/includes/admin/plugins.php#L280

ravinderk added a commit that referenced this issue May 7, 2018
feat(admin-plugins): display inline notification before updating #2789
@ravinderk
Copy link
Collaborator

This issue has been resolved but I am reopening this to test with few examples. I will close this if it will work fine for me.

@ravinderk ravinderk reopened this May 7, 2018
@ravinderk ravinderk assigned ravinderk and unassigned Sidsector9 May 7, 2018
@ravinderk
Copy link
Collaborator

@mathetos @DevinWalker working fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants