Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure sourcemaps are working properly #3860

Closed
DevinWalker opened this issue Nov 20, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@DevinWalker
Copy link
Member

commented Nov 20, 2018

Bug Report

User Story

As a developer, I want sourcemaps working so that I can easily inspect SaSS in dev tools.

Bug Type

  • This bug describes functionality that once worked as expected.

Acceptance Criteria

  • I can run npm run watch and view sourcemaps linking back to the appropriate SaSS line number.
@kakshak

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

Slack Call Summary

Participants: @kakshak @ravinderk @mehul0810
Topic: Discussion regarding sourcemap code in dev tools
Discussion: I and @ravinderk discuss this as I don't know much about sourcemaps but @ravinderk suggested that to check with @mehul0810 as there is no sourcemaps files are generated. So, I talked with @mehul0810 and he shows me that in dev tool sourcemaps files are not generated. So, I'll create one video and upload that in the comment for confirmation.

@kakshak

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

@DevinWalker @kevinwhoffman I've undrstood that right now, sourcemaps are not working properly for Give but we need to correct them and based on that I've recorded the video for what I understand for this task. Can you please look over it and let me know your thoughts on this?

Video

https://www.useloom.com/share/cb9f4896723f49c989ad0d7e375442a4

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Dec 6, 2018

@kakshak Yes. You are correct. This is an issue which we want to fix.

@kakshak

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

@kevinwhoffman I've looked over it and spent around 2 hours for this task and I think I required more time in it because I don't know much about sourcemaps functionality. Let me know if you want that I'll spent more time in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.