New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): implement optional honorifics/titles for Donor name #3011 #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehul0810
changed the title
feat(template): implement optional honorifics/titles for Donor name #3011
[WIP] feat(template): implement optional honorifics/titles for Donor name #3011
May 15, 2018
mehul0810
changed the title
[WIP] feat(template): implement optional honorifics/titles for Donor name #3011
feat(template): implement optional honorifics/titles for Donor name #3011
May 16, 2018
@mehul0810 there needs to be an option to make the new field either required or not required. Please add that option and resolve the merge conflict as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #3011
How Has This Been Tested?
I've tested this PR with the following scenarios:
Settings > Display Options > Display
Screenshots (jpeg or gifs if applicable):
Admin Settings
Donation Form MetaBox Settings
Name Title Prefix with dropdown closed
Name Title Prefix with dropdown open
Donation Receipt
Donation Emails
Donation Listing
Donation detail page
Donor Detail page
Donor Detail page with Edit Screen
Give API
Types of changes
New feature (a non-breaking change which adds functionality)
Checklist: