Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): implement optional honorifics/titles for Donor name #3011 #3228

Merged
merged 90 commits into from May 21, 2018

Conversation

mehul0810
Copy link
Contributor

@mehul0810 mehul0810 commented May 15, 2018

Description

This PR resolves #3011

How Has This Been Tested?

I've tested this PR with the following scenarios:

  • Add global settings under Settings > Display Options > Display
  • Add per-form settings with repeater field to provide titles for title prefix
  • Add new title prefix field on donation form in the front end
  • Add new title prefix field on donation detail page
  • Add new title prefix field on donor listing page
  • Add new title prefix field on donor detail page with the edit screen
  • Add title prefix in donation receipt
  • Add title prefix to email tags used in emails
  • Add title prefix in Give API

Screenshots (jpeg or gifs if applicable):

Admin Settings
image

Donation Form MetaBox Settings
image

Name Title Prefix with dropdown closed
image

Name Title Prefix with dropdown open
image

Donation Receipt
image

Donation Emails
image

Donation Listing
image

Donation detail page
image

Donor Detail page
image

Donor Detail page with Edit Screen
image

Give API
image

Types of changes

New feature (a non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mehul0810 mehul0810 changed the title feat(template): implement optional honorifics/titles for Donor name #3011 [WIP] feat(template): implement optional honorifics/titles for Donor name #3011 May 15, 2018
@mehul0810 mehul0810 changed the title [WIP] feat(template): implement optional honorifics/titles for Donor name #3011 feat(template): implement optional honorifics/titles for Donor name #3011 May 16, 2018
@DevinWalker
Copy link
Member

@mehul0810 there needs to be an option to make the new field either required or not required. Please add that option and resolve the merge conflict as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants