New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blocks #3827
Update blocks #3827
Conversation
@DevinWalker @kevinwhoffman Blocks are working fine for me. but i few point to improve this pr (maybe we can fork this and resolve issues in new branch ):
|
I am seeing different UI compared to screenshots shared, Testing on WP 5.0 Nightly build and twenty nineteen theme which is mostly theme conflict. Also, we no longer need custom rest endpoints for block rendering. |
@ajitbohra Thank you for pointing towards API points. We will deprecate them soon. I tested blocks with twenty nineteen theme and got the same results. Let me know if you can share the screenshots. |
Type of changes
Changes
Docker-compose
updated to mount cloned folder towp-content/plugins
InspectorControls
issue on WP 5.0wpApiSettings.schema.url
undefined on WP 5.0 via a JS utility function, can be done via giveApiSettings alsoshowTitle
option fromDonation Form Block
id
attribute not saving onDonation Form Block
WP 5.0
GiveLogo
component to display give logo, size and color can be customized as neededGiveLogo
componentServerSideRender
component for block preview instead of custom implementation duplicated across blocksSelectForm
data from block to its own component for separation of concernTesting
Some issue with frontend rendering on WP 5.0 With default theme