Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocks #3827

Merged
merged 13 commits into from Nov 12, 2018
Merged

Update blocks #3827

merged 13 commits into from Nov 12, 2018

Conversation

ajitbohra
Copy link
Contributor

@ajitbohra ajitbohra commented Nov 4, 2018

Type of changes

  • Blocks code refactor and clean up
  • Fix deprecated
  • Compatibility with WP 5.0 beta
  • Enhancements

Changes

  • Updated Docker-compose updated to mount cloned folder to wp-content/plugins
  • Fixed InspectorControls issue on WP 5.0
  • Fixed wpApiSettings.schema.url undefined on WP 5.0 via a JS utility function, can be done via giveApiSettings also
  • Restored missing showTitle option from Donation Form Block
  • Fixed id attribute not saving on Donation Form Block
  • Fixed broken preview style on WP 5.0
  • Added custom block category to group give blocks
  • Added new GiveLogo component to display give logo, size and color can be customized as needed
  • Refactored code to use new GiveLogo component
  • Refactored code to use ServerSideRender component for block preview instead of custom implementation duplicated across blocks
  • Decouple SelectForm data from block to its own component for separation of concern
  • Cleaned and refactored blocks

category

Testing

  • Tested on docker setup provided by plugin on WP 5.0 Nightly release with default theme for 5.0

Some issue with frontend rendering on WP 5.0 With default theme
frontend

@ravinderk
Copy link
Collaborator

@DevinWalker @kevinwhoffman Blocks are working fine for me. but i few point to improve this pr (maybe we can fork this and resolve issues in new branch ):

  1. Form styling issues:

image

image
image

  1. Donorwall styling issue:
    image

  2. Form Grid styling issue:
    image

@ravinderk ravinderk merged commit 1733292 into impress-org:release/2.3.1 Nov 12, 2018
@ajitbohra ajitbohra deleted the update/blocks branch November 13, 2018 11:49
@ajitbohra
Copy link
Contributor Author

@ravinderk

I am seeing different UI compared to screenshots shared, Testing on WP 5.0 Nightly build and twenty nineteen theme which is mostly theme conflict.

Also, we no longer need custom rest endpoints for block rendering.

@ravinderk
Copy link
Collaborator

@ajitbohra Thank you for pointing towards API points. We will deprecate them soon. I tested blocks with twenty nineteen theme and got the same results. Let me know if you can share the screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants