Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Editor Template #1111

Closed
ramiy opened this issue Oct 11, 2016 · 2 comments
Closed

Profile Editor Template #1111

ramiy opened this issue Oct 11, 2016 · 2 comments
Assignees
@ramiy
Milestone
1.7

Comments

@ramiy
Copy link
Contributor

ramiy commented Oct 11, 2016

Issue Overview

Field alignment issues.

Current Behavior

give-profile-current

Expected Behavior

give-profile-new

Possible Solution

  • The billing address fields should use the same class as all the other fields.
  • The password notice should have clear:both.
@mathetos
Copy link
Member

Good catch! Your annotations made me chuckle.

@ramiy
Copy link
Contributor Author

ramiy commented Oct 11, 2016 •
edited
Loading

Seems like the password notice was fixed in #998 .

@ramiy ramiy mentioned this issue Oct 11, 2016
Merged
@DevinWalker DevinWalker added this to the 1.7 milestone Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramiy ramiy

Labels
None yet
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
3 participants
@ramiy @mathetos @DevinWalker