Offline Donation Instructions email is blank by default in Give 1.8

[kevinwhoffman]

Issue Overview

Following a fresh install of Give 1.8... After submitting an offline donation, offline donation instructions are visible on the receipt. However, user also receives an email titled "Offline Donation Instructions" that has no instructions.

This occurs when Offline Donations are enabled globally and the form is set to use Global Options.

Expected Behavior

The same instructions that appear on the receipt should be visible in the email.

Current Behavior

Instructions appear in the receipt but not the email. See screenshots below.

Possible Solution

Go to Give Settings > Payment Gateways > Offline and click "Save changes." Future emails will now be populated as expected.

We should make sure that wherever the instructions are stored upon saving has a default value when Give is installed.

Steps to Reproduce (for bugs)

1. Install Give 1.8.
2. Create a new form and publish with default settings (Offline Donations set to Global Options).
3. Submit an offline donation.
4. Confirm that instructions are visible in receipt but not in email.
5. Go to Give Settings > Payment Gateways > Offline and click "Save changes."
6. Try a new offline donation.
7. Confirm email is populated with instructions as expected.