Logged in donations always default to the First Name/Last Name and email of that existing Give Donor.

[Benunc]

Issue Overview

This is related to #1481

Donations associated with existing Donor email addresses will always list the Firstname Lastname of the original donation.

Expected Behavior

Let's say LeRoy Jenkins is an existing Donor, having given in the past with the email address leroy@jenkins.com. Later he decides that he wants to go by Bobby. He submits a new donation as Bobby Jenkins, also tied to leroy@jenkins.com.

You'd expect that new donation to come from Bobby Jenkins. The donation should update the donor info.

Current Behavior

Currently, in the situation described above, the new donation from Bobby Jenkins will list the correct info on the Donation confirmation page, as well as the emailed receipt. But it is not listed correctly on the back end of the site under Donations --> Donations. The donor name is only listed as LeRoy, there's no trace of Bobby anywhere.

Interestingly, that info is still there, tied to the donation, and visible to Bobby/LeRoy if he logs in, and views the donation receipt in his browser. But his donor profile only has the first name.

Steps to Reproduce (for bugs)

1. From a logged out browser, submit two donations, changing the name, but keeping the same email.
2. From a logged in browser, check the Donation (or donor) on the back end. Both will have the first name.
3. Enable email access and validate the email from a logged out browser, and follow the link to the donation history page. That's the only spot you'll have that new donor firstname/last name.

Steps to reproduce something tangentially similar

1. Log in as an admin
2. Submit a donation as that admin
3. Submit another donation still logged in, but using a different email (one that doesn't exist in the DB)
4. View donations at Donations --> Donations.

All donations submitted while logged in seem to be tied to the same FirstName/LastName/Email, no matter what.

Related PRs

#1481