Database error on donations list page in backend in Windows 64-bit OS.

[emgk]

Issue Overview

Getting database error on donation list page and on other page(s) where this query executes.

This is because of the posts_per_page in class-payments-query.php#L832 is 999999999999999 which is not supported by Windows 64-bit so it converts this number to -1530494977.

PHP_INT_MAX for Windows OS are mentioned in this answer.

I am facing this issue in XAMPP and not in Local by flywheel ( because it runs on virtual Linux OS )

PS: as mentioned in this article we should not use -1 or too much large number for posts_per_page.

Expected Behavior

• Should not get the database error on windows 64bit OS.

Current Behavior

• Getting database error on donation list page.

Possible Solution

• Reducing value of posts_per_page to as much as possible.

Steps to Reproduce (for bugs)

1. Check it on Windows 64bit OS with XAMPP.
2. Go to donations list page in backend.

Related Issues and/or PRs

Todos

• Tests
• Documentation

WordPress Environment

``` ### WordPress Environment ###

Home URL: http://localhost/give18
Site URL: http://localhost/give18
WP Version: 4.9.1
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Inaccessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: localhost
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.25 (Win32) OpenSSL/1.0.2j PHP/7.0.18
PHP Version: 7.0.18
PHP Post Max Size: 8 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
PHP Max Upload Size: 2 MB
cURL Version: 7.51.0, OpenSSL/1.0.2j
SUHOSIN Installed: –
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ❌ Your server does not have the SoapClient class enabled - some gateway plugins which use SOAP may not work as expected.
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 1.8.18
Database Updates: 0 of 10 updates still need to run.
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://localhost/give18/donation-confirmation/
Failure Page: http://localhost/give18/donation-failed/
Donation History Page: http://localhost/give18/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Admin Email Notifications: Enabled
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Other Active Plugins

Inactive Plugins

Akismet Anti-Spam: by Automattic – 4.0.1
Give - Currency Switcher: by WordImpress – 1.0.0
Give - Fee Recovery: by WordImpress – 1.3.3
Hello Dolly: by Matt Mullenweg – 1.6

Theme

Name: Twenty Seventeen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

</details>