Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove usage of PHP 5.4+ shorthand bracket array declarations #3847

Closed
3 of 5 tasks
mehul0810 opened this issue Nov 16, 2018 · 0 comments
Closed
3 of 5 tasks

fix: remove usage of PHP 5.4+ shorthand bracket array declarations #3847

mehul0810 opened this issue Nov 16, 2018 · 0 comments
Assignees

Comments

@mehul0810
Copy link
Contributor

mehul0810 commented Nov 16, 2018

Bug Report

User Story

As a user, I want to use export tools properly so that it runs without any issue.

Current Behavior

Currently, I've noticed that there are 2 lines of code under export tool shows usage of shorthand array declaration which was introduced in PHP 5.4 which won't support 5.3.

Expected Behavior

I expect to run the export tool properly in PHP 5.3

Bug Type

  • This bug describes functionality that once worked in PHP 5.3 as expected in some versions earlier before commit 8fc6ee3.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Possible Solution

Acceptance Criteria

  • Use array() instead of [] for array declaration to support PHP 5.3
  • Testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants