fix: allow deletion of Address line 2 in French donation addresses

[Benunc]

Bug Report

User Story

As a site admin, I want to be able to delete the second line of a donor address when it's in France so that my records are correct.

Current Behavior

Currently, only for french addresses, you can't delete the second line of the address. Here's a screencast.
https://screencast-o-matic.com/watch/cqVXb63QMI

from the customer:

I have the impression that it works for countries with a state, and it doesn't work for countries without state. I tested for several countries.

Expected Behavior

I expect to be able to delete that second address line, no matter the country.

Bug Type

• This bug describes functionality that once worked as expected in version X.X.X.
• This bug describes functionality that never worked as expected.
• I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

1. Create a donation where address is required, and use France as the country
2. Navigate to the DONOR on the back end
3. Attempt to edit and remove the second line of the address.

Related

https://secure.helpscout.net/conversation/734046242/31245/

Acceptance Criteria

• No matter the country, admins can modify the address fields for donors with no problems.

Environment

WordPress System Info

### WordPress Environment ###

Home URL: http://sample.local
Site URL: http://sample.local
WP Version: 5.0.3
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: sample.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.10.1
PHP Version: 7.2.0
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.3.1
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access
Upgraded From: 2.3.1
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://sample.local/donation-confirmation/
Failure Page: http://sample.local/donation-failed/
Donation History Page: http://sample.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Stripe - Credit Card, PayPal Standard, Test Donation
Default Payment Gateway: Stripe - Credit Card
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Authorize.net Gateway: ❌ Unlicensed – by GiveWP – 1.4.4
Give - Stripe Gateway: ❌ Unlicensed – by GiveWP – 2.1.2
Give - Tributes: ❌ Unlicensed – by GiveWP – 1.5.2

Other Active Plugins

Inactive Plugins

Nefarious Unknown Plugin: by Enron McEquifax – 1.3
Plugin Detective - Troubleshooting: by N Squared – 1.1.2

Active MU Plugins

hide-give-license-warning.php: by –

Theme

Name: Twenty Seventeen
Version: 1.5
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme