Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for payment intent api in stripe core #4034

Closed
6 tasks done
mehul0810 opened this issue Mar 7, 2019 · 3 comments
Closed
6 tasks done

feat: add support for payment intent api in stripe core #4034

mehul0810 opened this issue Mar 7, 2019 · 3 comments
Assignees

Comments

@mehul0810
Copy link
Contributor

mehul0810 commented Mar 7, 2019

@mehul0810 commented on Tue Feb 05 2019

Feature Request

User Story

As a user, I want to accept donation via payment intent API approach so that accepting donation via any payment method is a streamlined process.

Note: Currently, card payments are only supported with Payment Intent API.

Discussion with Stripe Developers

Question 1: using payment intent approach over traditional approach with Stripe elements js (https://stripe.com/docs/stripe-js) is recommended... right? or we can use both as per our convenience? What are your recommendations?

one doesn't replace the other, they are complementary. A payment intent replaces the concept of creating tokens/sources and charges yourself. You would still use Elements, just instead of creating a token/source and sending to your backend to charge, you call handleCardPayment(https://stripe.com/docs/stripe-js/reference#stripe-handle-card-payment) with your payment intent, and we complete the charge for you using the information in the Element right now I'd 100% recommend integrating against payment intents for accepting card payments(it makes it much much easier to accept 3D Secure transactions, which is really important with upcoming EU regulations), and we'll expand intents over time to support other methods

Question 2: any other benefits for payment intent for accepting card payments?

the 3D Secure one is the main one, as that will be huge this year. Also, it's the only thing we're going to be recommending going forward, payment intents will be the new abstraction for accepting payments with Stripe and will tie into all our other products so it's worth integrating them now.

Related

Acceptance Criteria

  • Implement General Class to make Payment Intent API extendible.
  • Reseach and investigate the payment flow compatible with Give.
  • Ensure that onsite CC donations are processed successfully.
  • Pass additional parameters as required.
  • Ensure that offsite CC donations are processed successfully.
  • Testing
@mehul0810 mehul0810 changed the title feat: add support for payment intent api feat: add support for payment intent api in stripe core Mar 7, 2019
@mehul0810
Copy link
Contributor Author

mehul0810 commented Mar 7, 2019

As per the discussion with @DevinWalker, we agreed to start implementing the payment intent API so that our stripe core and its add-on will follow all the SCA regulations coming in Europe on 14 Sept 2019.

Note: Currently, Payment Intent API supports card payment type which includes onsite CC payments, offsite CC payments (i.e. Stripe Checkout ), and Payment Request (i.e. Apple/Google Pay) as per the documentation here https://stripe.com/docs/payments/payment-intents/migration

Adding this issue to EPIC

@mehul0810 mehul0810 self-assigned this Mar 7, 2019
@mehul0810
Copy link
Contributor Author

Slack Call Summary

Participants: @mehul0810 @ravinderk
Topic: Discussion on payment intent donation processing workflow.
Result: I showed the workflow of the donation processing using payment intent and it seems that the process is perfect to go with as discussed with Ravinder. However, I will show a demo on dev call tomorrow to discuss it further tomorrow.

@mehul0810
Copy link
Contributor Author

Closing this issue as this feature is implemented and is working fine with branch issue/4010 with one time donations for Stripe CC as well as Stripe Checkout. Class for payment intent implemented is extensible to use in Stripe premium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant