fix: donation marked as complete even if card is denied by Stripe #924 #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: merge dev to master for 2.6.1
release 2.6.2 merge into master
…curring/issue/924
DevinWalker
requested changes
Apr 29, 2020
There was a problem hiding this comment.
Please see my review of this PR: https://www.loom.com/share/9dc2312658ca43f39f884fb960bd9a4b
I'm requesting a few changes. Mainly, credit card declines and other errors related to the payment should result in a failed payment status in our plugin, not pending. As well, error logs should be title relevant to the error that occurred.
bradp
reviewed
May 6, 2020
includes/gateways/stripe/includes/class-give-stripe-customer.php
Outdated
Show resolved
Hide resolved
ravinderk
reviewed
May 7, 2020
includes/gateways/stripe/includes/class-give-stripe-customer.php
Outdated
Show resolved
Hide resolved
|
@DevinWalker I have generalized the error message under the logs. Also, to update you that the pending donation will not be created if the customer is not created. So, failing a donation is not possible. I have double-checked it at my end. We can discuss about this on today's call if required. |
ravinderk
requested changes
May 13, 2020
ravinderk
approved these changes
May 13, 2020
DevinWalker
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves https://github.com/impress-org/give-recurring/issues/924
Affects
What to test
As per the acceptance criteria on the issue.
Screenshots:
Video Link: https://www.loom.com/share/cae03ed23d1b40b6a3bcb8f0c2f4bcd2
Checklist: