fix: only show Manage Accounts on Form Settings if Stripe gateway is enabled

[mathetos]

Bug Report

User Story

As an Admin, when I create my GiveWP forms, I don't want to be confused by options that aren't relevant to me, so that I don't spend unneccessary time or configure something that might cause problems down the line.

Current Behavior

Currently, the "Manage Accounts" form settings tab appears on the Form edit screen regardless of whether any of the Stripe gateways are enabled or not.

Expected Behavior

I'd expect that the "Manage Accounts" tab on the form edit screen would appear only when/if a Stripe gateway is enabled.

Bug Type

• This bug describes functionality that never worked as expected.

Steps to Reproduce

1. Go to "Settings > Payment Gateways" and ensure that none of the Stripe gateways are enabled
2. Go to "Donations > Add Form" and confirm that the "Manage Accounts" tab is visible

Visuals

The "Manage Accounts" tab is visible:

Though none of the Stripe gateways are active:

Acceptance Criteria

• The "Manage Accounts" tab is visible when any Stripe gateway is enabled
• The "Manage Accounts" tab is NOT visible if ALL of the Stripe gateways are not enabled
• This fix does not negatively impact any of the other form edit tabs or gateway functionality in any way.

Environment

Operating System

• Platform: Microsoft Windows
• 10

Browser

• Name: Edge - Chromium
• Version: 83.0.478.45 -- 64 bit

WordPress System Info

### WordPress Environment ###

Home URL: https://give270test1.local
Site URL: https://give270test1.local
WP Version: 5.4.2
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: page
Page on Front: Home (#4)
Page for Posts: Unset
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: give270test1.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.16.0
PHP Version: 7.3.5
PHP Post Max Size: 1,000 MB
PHP Time Limit: 1200
PHP Max Input Vars: 4000
PHP Max Upload Size: 300 MB
cURL Version: 7.64.0, OpenSSL/1.1.1b
SUHOSIN Installed: –
MySQL Version: 5.7.28
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

GiveWP Configuration

GiveWP Version: 2.7.0
GiveWP Cache: Enabled
Database Updates: All DB Updates Completed.
Database Tables: ✔ wp_give_donors - 1.0✔ wp_give_donormeta - 1.0✔ wp_give_comments - 1.0✔ wp_give_commentmeta - 1.0✔ wp_give_sessions - 1.0✔ wp_give_logs - 1.0✔ wp_give_logmeta - 1.0✔ wp_give_formmeta - 1.0✔ wp_give_sequential_ordering - 1.0✔ wp_give_donationmeta - 1.0
GiveWP Cache: Enabled
GiveWP Cache: ❌New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions❌New User Registration✔User Registration Information✔Donation Note✔Email access
Upgraded From: 2.6.3
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: https://give270test1.local/thank-you-for-your-donation/
Failure Page: https://give270test1.local/donation-failed/
Donation History Page: https://give270test1.local/my-giving-history/
GiveWP Forms Slug: /donations/
Enabled Payment Gateways: PayPal Standard, Offline Donation
Default Payment Gateway: PayPal Standard
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled
Stripe Webhook Notifications: June 11, 2020 1:36 am

Active GiveWP Add-ons

Other Active Plugins

Akismet Anti-Spam: by Automattic – 4.1.6
Elementor: by Elementor.com – 2.9.12
Elementor Pro: by Elementor.com – 2.10.1
Instant Images: by Darren Cooney – 4.3.2
Starter Templates: by Brainstorm Force – 2.3.0
WPForms Lite: by WPForms – 1.6.0.2
WP Migrate DB Pro: by Delicious Brains – 1.9.10
WP Migrate DB Pro Media Files: by Delicious Brains – 1.4.15
WP Migrate DB Pro Theme & Plugin Files: by Delicious Brains – 1.0.5

Inactive Plugins

Form Countdown for GiveWP: by GiveWP – 2.0
Give - Annual Receipts: by GiveWP – 1.0.2
Give - Authorize.net Gateway: by GiveWP – 1.4.6
Give - Currency Switcher: by GiveWP – 1.3.7
Give - Email Reports: by GiveWP – 1.1.4
Give - Fee Recovery: by GiveWP – 1.7.8
Give - Form Field Manager: by GiveWP – 1.4.6
Give - PDF Receipts: by GiveWP – 2.3.8
Give - Recurring Donations: by GiveWP – 1.10.2
Give - Square: by GiveWP – 1.1.1
Give - Tributes: by GiveWP – 1.5.6
GiveWP Donation Widgets for Elementor: by GiveWP – 1.1.1
Per-Form Confirmation Pages for GiveWP: by GiveWP – 1.0
Pixabay Images: by Simon Steinberger – 3.4
Simple Social Shout for GiveWP: by GiveWP – 1.1.1

Active MU Plugins

Bypass Login: by Stephen Carnam – 1.1.0
WP Migrate DB Pro Compatibility: by Delicious Brains – 1.2

Theme

Name: give-demo
Version: 1.0.0
Author URL: http://wpastra.com/about/
Child Theme: Yes
Parent Theme Name: Astra
Parent Theme Version: 2.3.5
Parent Theme Author URL: https://wpastra.com/about/