Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push v1.0.0 to npm #653

Open
AdrienLemaire opened this issue Dec 21, 2017 · 3 comments
Open

push v1.0.0 to npm #653

AdrienLemaire opened this issue Dec 21, 2017 · 3 comments

Comments

@AdrienLemaire
Copy link

AdrienLemaire commented Dec 21, 2017

It took me a while to figure out why my local setup using the npm package wouldn't render the classic slides properly with help text & co. That's because the npm package is using the 0.6.0 release, while the example uses the 1.0.0 codebase.

Could you push the latest release on npm ?

Until then, I'll use yarn add https://github.com/impress/impress.js.git#1.0.0-beta1 :)

@AdrienLemaire
Copy link
Author

AdrienLemaire commented Dec 21, 2017

Strangely enough, I'm now forced to call the root div id "impress", and move all components to my bare index.html [see diff in this commit].
this is annoying, because I like having all my code in js files, and have it build by webpack.. No idea why this doesn't work anymore on v1.0.0

@henrikingo
Copy link
Contributor

Adrien, could you report the second comment as a separate issue. Probably somewhere I have hard coded 'impress', which is wrong.

I was planning to push a new npm later, after I fix the issues that have already been reported against 1.0.0-beta1.

@simplePCBuilding
Copy link
Contributor

Done, can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants