Remove bucket operator metrics #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jojohappy <sarahdj0917@gmail.com>
jojohappy
force-pushed
the
remove_bucket_operator_metrics
branch
from
3e79b15
to
c52ad1c
Compare
|
I think we need to add something to change log that we are killing those gcs and s3 metrics! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jojohappy sarahdj0917@gmail.com
Changes
Related comments: #467
The bucket operator metrics in each bucket are unnecessary, because we wrap the instance of bucket in the
metricBucket, those seem to be duplicated. Let's remove the metrics and we can add again when support multiple buckets.Verification
In Thanos Query UI, we can just find the
thanos_objstore_bucket_operations_total, nothanos_objstore_s3_bucket_operations_totalorthanos_objstore_gcs_bucket_operations_totaletc..