Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniformVertex upper bound is not inclusive #380

Closed
CharlieCrisp opened this issue Dec 4, 2018 · 1 comment
Closed

UniformVertex upper bound is not inclusive #380

CharlieCrisp opened this issue Dec 4, 2018 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@CharlieCrisp
Copy link
Contributor

Describe the bug
The UniformVertex allows you to specify upper and lower bounds but the upper bound is exclusive and doing a logProb() at this value will give -Infinity.

To Reproduce

UniformVertex vertex = new UniformVertex(0.0, 1.0);
vertex.setValue(1.0);
vertex.logProbAtValue();

Expected behavior
Upper bound should be inclusive

@GeorgeNash GeorgeNash added the question Further information is requested label Dec 4, 2018
@GeorgeNash
Copy link
Contributor

This has been intentionally done to make it easy to map from RNG's. @gordoncaleb has opinions on this so I'll loop him back in when he's back from holiday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants