Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still alive? #92

Closed
yousefamar opened this issue Mar 29, 2020 · 5 comments
Closed

Is this project still alive? #92

yousefamar opened this issue Mar 29, 2020 · 5 comments

Comments

@yousefamar
Copy link
Collaborator

It seems like even small maintenance, like accepting PRs for security updates, has been on ice for years now. Are you still maintaining this repo? I think it would be a shame to let it die and/or splinter into a million forks, especially since the only other Node.js wrapper linked in the API docs is even more dead.

If you're no longer interested in maintaining this project, I would gladly offer to do so for you, here and on npm.

@mocanew
Copy link

mocanew commented Mar 29, 2020

We continued to improve on @impronunciable initial work over on moviedb-promise. Usually, @grantholle is very quick to respond to issues and PRs.

It would be awesome if someone took over maintaining the moviedb package so that we won't have multiple similar packages/repos for the same API.

@impronunciable
Copy link
Owner

Hi @yousefamar thank you for the offer. I added you as mantainer :) let me know if you have any questions and feel free to continue working on it.

@impronunciable
Copy link
Owner

@rontav Is it also great to know you used this code an improved it 👍

@grantholle
Copy link
Contributor

@yousefamar You're welcome to contribute on the moviedb-promise package. I recently ported it to TypeScript and think it would be really cool to be able to add types for the different requests and responses, but would require a lot of manual labor. Their docs have all of that info so it's just a matter of copying and pasting.

@impronunciable I also think it would be cool to merge the two projects, although I don't know the logistics of how that would go down. I try to stay on top of issues and PR's

@impronunciable
Copy link
Owner

@grantholle didn't know about your package. I'm glad you worked on it. Since I'm not actively working on this I'd accept a PR with a deprecation notice and a link to your repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants