You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As you pointed out in the README.md, the default false behavior of fail-fast might accrue a long and expensive run time.
If the default behavior of fail-fast were true, when the rate-limit is reached, users would instantly be notified of the failed workflow run.
Users would then be allowed to act accordingly. (Some may simply wait it out; others may choose to explicitly turn off fail-fast.)
On the other hand, if the default behavior of fail-fast is false (as it currently is now), when the rate-limit is reached,
the github workflow will silently run for a long time (theoretically up to an additional 1 hour) without any particular notice to the user.
Worst case scenario, github user will not notice anything until they are met with an expensive bill at the end of their payment cycle (= 1 month or, worse, 1 year).
May I ask would you be willing to release a v2 major version update (because it's a breaking change) where fail-fast default is true?
I think it's good practice and in good faith to the community to have the less silently dangerous option be the default.
The text was updated successfully, but these errors were encountered:
Hey @imranismail, hope this finds you well.
As you pointed out in the README.md, the default
false
behavior offail-fast
might accrue a long and expensive run time.If the default behavior of
fail-fast
weretrue
, when the rate-limit is reached, users would instantly be notified of the failed workflow run.Users would then be allowed to act accordingly. (Some may simply wait it out; others may choose to explicitly turn off
fail-fast
.)On the other hand, if the default behavior of
fail-fast
isfalse
(as it currently is now), when the rate-limit is reached,the github workflow will silently run for a long time (theoretically up to an additional 1 hour) without any particular notice to the user.
Worst case scenario, github user will not notice anything until they are met with an expensive bill at the end of their payment cycle (= 1 month or, worse, 1 year).
May I ask would you be willing to release a
v2
major version update (because it's a breaking change) wherefail-fast
default istrue
?I think it's good practice and in good faith to the community to have the less silently dangerous option be the default.
The text was updated successfully, but these errors were encountered: