Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML app source problem: Could not get ID from APK #1077

Closed
custompyramidfellow opened this issue Nov 8, 2023 · 1 comment
Closed

HTML app source problem: Could not get ID from APK #1077

custompyramidfellow opened this issue Nov 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@custompyramidfellow
Copy link

Describe the bug
I want to use Obtanium to download latest TOR browser apk aarch64 for Android from
https://torproject.org/download/
But I can't get it to work.

Thanks for your help.

To Reproduce

  1. If I just add the URL via Add App it takes a while to scrape and gets added to Obtanium but if I hit Install it just gives error "Incompatible App"

  2. If I add the URL and Custom APK link filter "tor-browser-android-aarch64" it gives me immediately error: "Could not get ID from APK" and doesnt even get added to Obtanium

  3. If I add the URL, and Custom APK link filter "tor-browser-android-aarch64", and version extraction "aarch64-([0-9]+.)*[0-9]+" same error: "Could not get ID from APK"

Please complete the following information:

  • Device: Pixel 7
  • OS: GrapheneOS
  • Obtainium Version: 0.14.32
@custompyramidfellow custompyramidfellow added bug Something isn't working to check Issue has not been reviewed labels Nov 8, 2023
@ImranR98
Copy link
Owner

ImranR98 commented Nov 9, 2023

Observations explained:

  1. The default APK being picked is the last one after sorting alphabetically which is x86_64 which isn't compatible with your phone.
  2. Since you've used your own link filter, the default filter (which filters out all links not ending in .apk) is no longer used. So the filter matches two links on the page - the .apk link you need, but also the .apk.asc link ("Sig" button on the page). The latter is picked since it is the last one after sorting.
  3. Same as 2.

So the solution is to use a regex like aarch64.*apk$ which will filter out the .asc link. For version extraction, ([0-9]+\.)*[0-9]+ will work.

@ImranR98 ImranR98 removed the to check Issue has not been reviewed label Nov 9, 2023
@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants