Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to search apps using Github api #40

Closed
ph00lt0 opened this issue Oct 2, 2022 · 5 comments
Closed

Add option to search apps using Github api #40

ph00lt0 opened this issue Oct 2, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@ph00lt0
Copy link

ph00lt0 commented Oct 2, 2022

As a way to move more to apps discovery I think a great start would be to utilize the option to use API keys of GitHub to search repositories. Ideally these would be filtered based on the results having releases with an APK file.

This all would remove the requirement to find the url of the app and copy it over etc.

@ImranR98
Copy link
Owner

ImranR98 commented Oct 2, 2022

This is a good idea, but i'm not sure about filtering results to get rid of non-APK releases, because there could be 100s of results and checking each needs one API request so even a user with a token could run out quickly (and it would take a long time). But yeah, allowing the user to search then pick a result can be looked into.

@ImranR98 ImranR98 added the enhancement New feature or request label Oct 2, 2022
@ph00lt0
Copy link
Author

ph00lt0 commented Oct 2, 2022

i think the token running out is not so likely. I use an app called raycast to search github repo's and I never hit a limit. Filtering is def, a challenge. Even without the filter it could already help to add apps people know.

@S7venLights
Copy link

Is there no official way that Github devs designate what platform their repos target? Like a Tag for android?
If there is, you could use that as a filter

@ImranR98
Copy link
Owner

ImranR98 commented Nov 12, 2022

Added: https://github.com/ImranR98/Obtainium/releases/tag/v0.7.0-beta

No way to filter only for android Apps as far as I can see, so it's up to the user to recognize what they want.
For now the results only show App name/author since that was easiest to implement, but I'll add App descriptions and URL links later to make it easier to pick results. Leaving the issue open till then.

@ImranR98
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants