Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Mime Type and Quality #1

Open
furey opened this issue Feb 12, 2020 · 1 comment
Open

Feature Request: Mime Type and Quality #1

furey opened this issue Feb 12, 2020 · 1 comment

Comments

@furey
Copy link

furey commented Feb 12, 2020

Hi! 馃憢

Thanks so much for your fantastic library!

Would you consider adding mime type and quality parameters to your type() method?

.type(['objectURL', 'image/jpeg', 0.95])

Looking at the repository source, I seed objectURL uses toBlob and base64 uses toDataURL鈥攂oth HTMLCanvasElement methods that support additional mime type and quality arguments:

Hope this is a feature you'll consider implementing!

Cheers!

馃馃憤

@imshaikot
Copy link
Owner

@furey Thank you for your consideration and suggestion.
It sounds really good addition to the configuration.
As I don't have any written test for this small library and I also wanted to add some unit tests.
Therefore it may take a little while for me to add that feature.

You are more than welcome to make a pull request meanwhile and I can publish the update.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants