Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request reviews instead of assigning to PR #90

Closed
emmiegit opened this issue Feb 10, 2019 · 1 comment
Closed

Request reviews instead of assigning to PR #90

emmiegit opened this issue Feb 10, 2019 · 1 comment

Comments

@emmiegit
Copy link

GitHub has had reviews for some time now, and I think it would make more sense if pull-review used that instead of assigning. People viewing the PR would also see the "XXX has requested a review" which better communicates intent.
@imsky
Copy link
Owner

imsky commented Feb 11, 2019

this is already implemented https://github.com/imsky/pull-review#use_review_requests

@imsky imsky closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imsky @emmiegit